Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add travis-ci docker image pipeline #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ghost
Copy link

@ghost ghost commented Jul 30, 2019

Resolves #53

Unable to fully test this as TravisCI does not run on forks, and Docker Hub credentials need to be setup.


before_deploy:
- export DOCKER_IMAGE_TAG=${DOCKER_IMAGE}:${TRAVIS_TAG}
- echo "${DOCKER_PASSWORD}" | docker login -u "${DOCKER_USERNAME}" --password-stdin
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DOCKER_USERNAME and DOCKER_PASSWORD need to be set by a repo owner after setting up on travis and docker hub.

See https://docs.travis-ci.com/user/environment-variables/#defining-variables-in-repository-settings

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jacobcabantomski-ct mind hard forking this and setting up the publicly-available Docker image on your fork? I'd be interested in this too and clearly the author is not maintaining this repo anymore.

@ghost ghost mentioned this pull request Jul 30, 2019
@ghost
Copy link
Author

ghost commented Jul 20, 2020

@JaneJeon I can look into some options but it does look like there have been several updates this year to the repo by @mcguinness and others. I would prefer to have the image be based upon the latest source if possible and updated automatically via CI/CD (Maybe GitHub Actions now instead of Travis CI).

If you need an image before then I would recommend building and pushing up your own. This has the added benefit of using a stable commit you know works for you.

https://github.com/mcguinness/saml-idp#docker

# assuming you are in root of repo
docker build . -t janejeon/saml-idp:latest
docker push janejeon/saml-idp:latest

@mcguinness
Copy link
Owner

I am maintaining the code. Is the ask here just to publish an image to docker hub on each release? What else is needed besides a .travis.yml file for CI/CD workflows? I am assuming the Dockerfile in the repo is fine, does that need any changes?

@ghost
Copy link
Author

ghost commented Jul 20, 2020

@mcguinness I think everything Docker related is already good to go, just the CI/CD workflow to publish an image on each release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Docker Image
3 participants