Set default value of step_info.preferredbehaviour to 'adaptive' rathe…

…r than a meaningless 0.
mckeownp · Apr 18, 2024 · c2bbd17 · c2bbd17
1 parent 306c2f2
commit c2bbd17
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/question.php b/question.php
@@ -949,10 +949,10 @@ private function get_attached_files($response) {
 
     private static function step_info($response) {
         $stepinfo = new stdClass();
-        foreach (['numchecks', 'numprechecks', 'fraction', 'preferredbehaviour'] as $key) {
-            $value = isset($response[$key]) ? $response[$key] : 0;
-            $stepinfo->$key = $value;
+        foreach (['numchecks', 'numprechecks', 'fraction'] as $key) {
+            $stepinfo->$key = $response[$key] ?? 0;
         }
+        $stepinfo->preferredbehaviour = $response['preferredbehaviour'] ?? 'adaptive';
         $stepinfo->coderunnerversion = get_config('qtype_coderunner')->version;
         return $stepinfo;
     }

diff --git a/tests/behat/check_twig_student_variable.feature b/tests/behat/check_twig_student_variable.feature
@@ -33,7 +33,7 @@ Feature: Check the STUDENT Twig variable allows access to current username in Co
       | id_answerboxlines       | 5                                          |
       | id_validateonsave       | 0                                          |
       | id_template             | {{ STUDENT_ANSWER }}                       |
-      | id_answer               | print("{{STUDENT.username}}"               |
+      | id_answer               | print("{{STUDENT.username}})"              |
       | id_iscombinatortemplate | 0                                          |
       | id_testcode_0           | # This isn't used                          |
       | id_expected_0           | {{ STUDENT.username }}                     |