Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vizro_ai_integration_tests #146

Merged
merged 6 commits into from
Nov 6, 2023
Merged

vizro_ai_integration_tests #146

merged 6 commits into from
Nov 6, 2023

Conversation

l0uden
Copy link
Contributor

@l0uden l0uden commented Nov 2, 2023

Description

integration tests for checking correct response of vizro-ai

Screenshot

Checklist

  • I have not referenced individuals, products or companies in any commits, directly or indirectly
  • I have not added data or restricted code in any commits, directly or indirectly
  • I have updated the docstring of any public function/class/model changed
  • I have added tests to cover my changes (if applicable)

Types of changes

  • Docs/refactoring (non-breaking change which improves codebase)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.

@l0uden l0uden marked this pull request as ready for review November 2, 2023 16:50
Copy link
Contributor

@Anna-Xiong Anna-Xiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@l0uden Hi Alexey, can you add one small change of the dev version. @maxschulz-COL what would be the current version if we want to bump test pacakge? thank you!

@maxschulz-COL
Copy link
Contributor

@l0uden Hi Alexey, can you add one small change of the dev version. @maxschulz-COL what would be the current version if we want to bump test pacakge? thank you!

Wait I don't understand, what do you mean?

@Anna-Xiong
Copy link
Contributor

Anna-Xiong commented Nov 3, 2023

@l0uden Hi Alexey, can you add one small change of the dev version. @maxschulz-COL what would be the current version if we want to bump test pacakge? thank you!

Wait I don't understand, what do you mean?

the test pypi version we want to update with the newest merge, do we want to bump the version or it should be fine to use the same version and just replace it?

@maxschulz-COL
Copy link
Contributor

Ah ok got it! I already published a dev1 version earlier, so @l0uden can you make this dev2, just type hatch version dev twice

Copy link
Contributor

@maxschulz-COL maxschulz-COL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, please do not forget to update the dev version and to adjust the conditions under which this has to run

@Anna-Xiong Anna-Xiong self-requested a review November 3, 2023 13:53
Copy link
Contributor

@Anna-Xiong Anna-Xiong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@l0uden
Copy link
Contributor Author

l0uden commented Nov 3, 2023

adjust the conditions under which this has to run

@maxschulz-COL, what does it mean?

@l0uden l0uden merged commit bef5c12 into main Nov 6, 2023
18 checks passed
@l0uden l0uden deleted the ci/vizro_ai_integration_tests branch November 6, 2023 11:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants