Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Docs] Prepare docs for refactoring #678

Merged
merged 106 commits into from
Sep 20, 2024
Merged

[Docs] Prepare docs for refactoring #678

merged 106 commits into from
Sep 20, 2024

Conversation

maxschulz-COL
Copy link
Contributor

@maxschulz-COL maxschulz-COL commented Sep 3, 2024

Description

  • sharp eyes definitely needed as I will 100% have forgotten something 😬
  • also noted the first performance decrease compared to the previous iteration: the prompt in the chart tutorial for the line chart of GDP over the years (around line 72) works without the extra statement about taking the average in the previous version --> can anyone find similar cases?

Screenshot

Notice

  • I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":

    • I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
    • I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
    • I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
    • I have not referenced individuals, products or companies in any commits, directly or indirectly.
    • I have not added data or restricted code in any commits, directly or indirectly.

maxschulz-COL and others added 30 commits August 19, 2024 10:13
Copy link
Contributor

@lingyielia lingyielia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed, dashboard is not compatible with other vendors yet. Otherwise LGTM!

@maxschulz-COL maxschulz-COL added the Vizro-AI 🤖 Issue/PR that addresses Vizro-AI package label Sep 6, 2024
Copy link
Contributor

@nadijagraca nadijagraca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I didn't have trouble following the instructions and replicating the examples. ⭐

Base automatically changed from poc/vizro_ai_charts_refactor to main September 20, 2024 13:31
@lingyielia lingyielia merged commit bb6a99f into main Sep 20, 2024
39 of 40 checks passed
@lingyielia lingyielia deleted the docs/vizro_ai_docs branch September 20, 2024 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Vizro-AI 🤖 Issue/PR that addresses Vizro-AI package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants