[Fix] Remove double loading of data #802
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A special treat for @petar-qb to find when he's feeling better 😀 Probably the easiest optimisation we could have made. Thank you to him for spotting this horrible inefficiency that I had written in the code!
Functionally this is exactly the same as before. It's just better performing. Previously doing
kwargs.setdefault
always ran the.load()
function. Now we only want to run it if it's strictly required (which in Vizro at the moment it actually never is, but I saw someone doinggraph()
the other day so they were using it, and maybe we will in future).Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":