-
Notifications
You must be signed in to change notification settings - Fork 144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feat] Drop Python 3.8 and add Python 3.13 support to Vizro #813
Conversation
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 Just one minor question
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good.
vizro-ai/changelog.d/20241016_133757_antony.milne_bump_python_py39.md
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
LGTM, no docs observations |
Description
ruff
, especiallypyupgrade
which has helped to update our codebase to Python 3.9+.from typing import List, Dict, ...
- you can just use the builtinlist
etc. 🎉from __future__ import annotations
because of pydantic. So we still need to do the uglyUnion
andOptional
. When we drop Python 3.9 in a year's time this will gohatch run schema
depending on Python version now so we can finally tidy up that job to not depend on a specific version.hatch run schema-check
any moreTODO:
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":