[QA] VizroAI UI tests #882

l0uden · 2024-11-18T12:12:50Z

Description

Moved VizroAI UI tests from vizro-qa

Notice

I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":
- I submit this contribution under the Apache 2.0 license and represent that I am entitled to do so on behalf of myself, my employer, or relevant third parties, as applicable.
- I certify that (a) this contribution is my original creation and / or (b) to the extent it is not my original creation, I am authorized to submit this contribution on behalf of the original creator(s) or their licensees.
- I certify that the use of this contribution as authorized by the Apache 2.0 license does not violate the intellectual property rights of anyone else.
- I have not referenced individuals, products or companies in any commits, directly or indirectly.
- I have not added data or restricted code in any commits, directly or indirectly.

for more information, see https://pre-commit.ci

…onent_library_tests

for more information, see https://pre-commit.ci

github-actions · 2024-11-18T12:14:06Z

View the example dashboards of the current commit live on PyCafe ☕ 🚀

Updated on: 2024-12-12 12:42:53 UTC
Commit: bb0b680

Link: vizro-core/examples/dev/

Link: vizro-core/examples/scratch_dev

Link: vizro-core/examples/visual-vocabulary/

Link: vizro-ai/examples/dashboard_ui/

…o_ai_ui_tests � Conflicts: � .github/workflows/vizro-qa-tests-trigger.yml � vizro-core/hatch.toml

for more information, see https://pre-commit.ci

into qa/vizro_ai_ui_tests � Conflicts: � vizro-ai/tests/e2e/test_vizro_ai_ui.py

…o_ai_ui_tests

for more information, see https://pre-commit.ci

into qa/vizro_ai_ui_tests

maxschulz-COL

Thanks @l0uden , added a few comments

maxschulz-COL · 2024-12-17T10:19:20Z

vizro-ai/hatch.toml

@@ -48,6 +48,7 @@ prep-release = [
 ]
 pypath = "hatch run python -c 'import sys; print(sys.executable)'"
 test = "pytest tests {args}"
+test-e2e-vizro-ai-ui = "pytest -vs --reruns 1 tests/e2e/test_vizro_ai_ui.py --headless {args}"


If we add this as a hatch script, does it run locally if I was to use that command?

Yes, anyway to use it you need to run the VIzroAI UI first

maxschulz-COL · 2024-12-17T10:20:12Z

vizro-ai/hatch.toml

@@ -56,6 +57,7 @@ test-unit-coverage = [
  "- coverage combine",
  "coverage report"
 ]
+vizro-ai-ui = "python examples/dashboard_ui/app.py &"


Is this hatch command really necessary? Could this not work like the other examples in vizro-core where the user can specify the example by providing args

Couldn't do it. Let's take a look a this way together

maxschulz-COL · 2024-12-17T10:22:11Z

vizro-ai/pyproject.toml

 ]
+norecursedirs = ["tests/tests_utils"]


What does that do?

Wanted to do it as in vizro-core repo, but looks like here it doesn't have any sense. Thanks. Deleted

maxschulz-COL · 2024-12-17T10:36:01Z

vizro-ai/tests/tests_utils/__init__.py

I think it might be better to have a test_utils also per folder, like here for e2e? Then you could save yourself also all the e2e file prefixes?

My point was to make same folder structure as in vizro-core for the tests.

maxschulz-COL · 2024-12-17T10:36:38Z

vizro-ai/tests/tests_utils/wait-for-it.sh

@@ -0,0 +1,204 @@
+#!/usr/bin/env bash
+
+#The MIT License (MIT)


Why do we have a license here?

I took this file from the repo which has MIT license, in this case we should specify it.

…o_ai_ui_tests

for more information, see https://pre-commit.ci

into qa/vizro_ai_ui_tests � Conflicts: � vizro-core/hatch.toml

for more information, see https://pre-commit.ci

into qa/vizro_ai_ui_tests

l0uden and others added 10 commits November 13, 2024 18:58

component library tests

ea31d69

[pre-commit.ci] auto fixes from pre-commit.com hooks

c656536

for more information, see https://pre-commit.ci

failed artifacts and slack notifications

40a293e

branch in notification

3283d74

delete screenshot

3cff909

add screenshot

8fe3812

fix screenshot url

ab843c8

Merge branch 'main' of https://github.com/mckinsey/vizro into qa/comp…

f9de666

…onent_library_tests

changelog

d74645f

vizroAI UI tests

2af4dce

github-actions bot added the Vizro-AI 🤖 Issue/PR that addresses Vizro-AI package label Nov 18, 2024

l0uden changed the base branch from main to qa/component_library_tests November 18, 2024 12:13

[pre-commit.ci] auto fixes from pre-commit.com hooks

aeb063f

for more information, see https://pre-commit.ci

l0uden changed the base branch from qa/component_library_tests to main November 18, 2024 12:14

l0uden changed the base branch from main to qa/component_library_tests November 18, 2024 12:20

l0uden added 8 commits November 18, 2024 13:21

added PR branch for tests

8ad3e4e

fix for runner name

9ff0bbb

requirements for tests env

4d826f0

run app under hatch

73ba50a

return headless mode

1bc78c8

test failure

f5a67bf

test failure

fbbb2a0

test success

5b6c718

Base automatically changed from qa/component_library_tests to main November 26, 2024 11:11

l0uden and others added 5 commits December 12, 2024 13:41

Merge branch 'main' of https://github.com/mckinsey/vizro into qa/vizr…

bb0b680

…o_ai_ui_tests � Conflicts: � .github/workflows/vizro-qa-tests-trigger.yml � vizro-core/hatch.toml

fix merging main

ea7ef47

tests refactor

2ffdbe6

[pre-commit.ci] auto fixes from pre-commit.com hooks

41b6a97

for more information, see https://pre-commit.ci

delete data csv

aaa805d

l0uden and others added 6 commits December 13, 2024 16:09

Merge branch 'qa/vizro_ai_ui_tests' of https://github.com/mckinsey/vizro

5f0f3ce

into qa/vizro_ai_ui_tests � Conflicts: � vizro-ai/tests/e2e/test_vizro_ai_ui.py

Merge branch 'main' of https://github.com/mckinsey/vizro into qa/vizr…

255b847

…o_ai_ui_tests

[pre-commit.ci] auto fixes from pre-commit.com hooks

efc1acc

for more information, see https://pre-commit.ci

test failed

d68d17d

Merge branch 'qa/vizro_ai_ui_tests' of https://github.com/mckinsey/vizro

4905fe7

into qa/vizro_ai_ui_tests

test success

f85aa78

l0uden marked this pull request as ready for review December 16, 2024 11:01

l0uden requested review from Joseph-Perkins, antonymilne, huong-li-nguyen, maxschulz-COL and lingyielia as code owners December 16, 2024 11:01

maxschulz-COL reviewed Dec 17, 2024

View reviewed changes

l0uden and others added 10 commits December 24, 2024 12:30

small refactoring

ad807f9

Merge branch 'main' of https://github.com/mckinsey/vizro into qa/vizr…

f2792be

…o_ai_ui_tests

changelog

84be043

temp uv fix

ebc2465

[pre-commit.ci] auto fixes from pre-commit.com hooks

530d3fe

for more information, see https://pre-commit.ci

temp uv fix

01dcdc6

Merge branch 'qa/vizro_ai_ui_tests' of https://github.com/mckinsey/vizro

7c78959

into qa/vizro_ai_ui_tests � Conflicts: � vizro-core/hatch.toml

[pre-commit.ci] auto fixes from pre-commit.com hooks

4f93588

for more information, see https://pre-commit.ci

get conftest back to integration

986872b

Merge branch 'qa/vizro_ai_ui_tests' of https://github.com/mckinsey/vizro

725b7b2

into qa/vizro_ai_ui_tests

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[QA] VizroAI UI tests #882

[QA] VizroAI UI tests #882

l0uden commented Nov 18, 2024

github-actions bot commented Nov 18, 2024 •

edited

Loading

maxschulz-COL left a comment

maxschulz-COL Dec 17, 2024

l0uden Dec 18, 2024

maxschulz-COL Dec 17, 2024

l0uden Dec 24, 2024

maxschulz-COL Dec 17, 2024

l0uden Dec 18, 2024

maxschulz-COL Dec 17, 2024

l0uden Dec 18, 2024

maxschulz-COL Dec 17, 2024

l0uden Dec 18, 2024

		]
		norecursedirs = ["tests/tests_utils"]

[QA] VizroAI UI tests #882

Are you sure you want to change the base?

[QA] VizroAI UI tests #882

Conversation

l0uden commented Nov 18, 2024

Description

Notice

github-actions bot commented Nov 18, 2024 • edited Loading

View the example dashboards of the current commit live on PyCafe ☕ 🚀

maxschulz-COL left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

github-actions bot commented Nov 18, 2024 •

edited

Loading