-
Notifications
You must be signed in to change notification settings - Fork 145
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Restructure of Vizro-AI dashboard docs #883
[Docs] Restructure of Vizro-AI dashboard docs #883
Conversation
for more information, see https://pre-commit.ci
View the example dashboards of the current commit live on PyCafe ☕ 🚀Updated on: 2024-11-21 12:23:44 UTC Link: vizro-core/examples/dev/ Link: vizro-core/examples/scratch_dev |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Didn't read in last detail, will leave that to @stichbury, but this is I think a great improvement
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Just a few suggestions. Please can you also run Vale over the text (introduce a deliberate error to trigger it to give you all the warnings/suggestions too) so that you catch any typos and use of words like "provide" that I have missed. No need to fix anything in Vizro-Core but if you find any in Vizro-AI please can you address them?
I have trouble running vale, I get the exact error you posted on vizro-dev channel few weeks ago. For now, I'm relying on CI to lint. |
I'll make a commit that "breaks" it and we'll see what Vale suggestions/warnings come up. |
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Jo Stichbury <jo_stichbury@mckinsey.com>
Description
scrap the entire Examples section for a tab that says: Try out! (this would lead to vizro.mckinsey.com)
add the chart examples under Advanced charts (basically as a kind of user guide), each chart in its own category
combine Generate a complex dashboard and Retrieve code for a generated dashboard into a new Run vizro_ai.dashboard to match exactly what we have for charts, significantly reducing the repeat on the code generation page, which always annoyed me (this would make the two sections align), ideally using a very! simple dashboard prompt
Add the more complex dashboard examples under a new page that mimics the Generate a complex dashboard one
remove the component table on the home page (the one that says whats possible) and add it in the new Run vizro-ai.dashboard, where it really belongs
(bonus) Add a similarly awesome gif to the chart creation one for the dashboard creation on both the homepage and the README - will be added in another PR
Screenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":