Cmd history #1
Merged
Cmd history #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This implementation works on embedded targets and in the Linux demo
but code is still a bit of 'work in progress'.
Work that remains:
- All examples shall be updated with 'ush_history' struct.
- Implement unit tests for new 'ush_history.c' source file.
- Tweak implementation so behavior is more like Linux shell:
- Current line is saved when using up/down arrows.
- Changes to history lines is saved when using up/down arrows.
Work according to 'TODO:' comments in source code:
- Implement autocomplete using history lines in the future.
- Add unit test for state USH_STATE_READ_CHAR_BUFFER.
This implementation works on embedded targets and in the Linux demo
but code is still a bit of 'work in progress'.
Work that remains:
- All examples shall be updated with 'ush_history' struct.
- Implement unit tests for new 'ush_history.c' source file.
- Tweak implementation so behavior is more like Linux shell:
- Current line is saved when using up/down arrows.
- Changes to history lines is saved when using up/down arrows.
Work according to 'TODO:' comments in source code:
- Implement autocomplete using history lines in the future.
- Add unit test for state USH_STATE_READ_CHAR_BUFFER.
…oshell into issue6_cmd_history
Unit tests are to be added later.
…mand history with up/down arrows feature)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement command history with either up/down arrows or ctrl+a/ctrl+z. The control key combos are added because they send only a single byte, whereas up/down arrows send 3 bytes - on some systems the character processing may not be fast enough to digest the full escape codes.