BREAKING: Improve types and type validation (MetaMask#19)

* Improve types and type validation * Fix JsonRpcSuccess type * Add functions to check if a value is a JsonRpcResponse * Fix error message * Add test vectors * Move test.data to fixtures folder * Improve error messages
mcmire · Aug 3, 2022 · 5cc6b38 · 5cc6b38
1 parent 08a783e
commit 5cc6b38
Show file tree

Hide file tree

Showing 9 changed files with 1,188 additions and 372 deletions.
diff --git a/merged-packages/utils/jest.config.js b/merged-packages/utils/jest.config.js
@@ -2,7 +2,7 @@ module.exports = {
   collectCoverage: true,
   // Ensures that we collect coverage from all source files, not just tested
   // ones.
-  collectCoverageFrom: ['./src/**/*.ts'],
+  collectCoverageFrom: ['./src/**/*.ts', '!./src/__fixtures__/**/*'],
   coverageReporters: ['text', 'html'],
   coverageThreshold: {
     global: {

diff --git a/merged-packages/utils/package.json b/merged-packages/utils/package.json
@@ -27,7 +27,8 @@
     "docs:publish": "typedoc --cleanOutputDir false --gitRevision \"v$(jq -r .version < ./package.json)\""
   },
   "dependencies": {
-    "fast-deep-equal": "^3.1.3"
+    "fast-deep-equal": "^3.1.3",
+    "superstruct": "^0.16.0"
   },
   "devDependencies": {
     "@lavamoat/allow-scripts": "^1.0.5",

diff --git a/merged-packages/utils/src/__fixtures__/index.ts b/merged-packages/utils/src/__fixtures__/index.ts
@@ -0,0 +1 @@
+export * from './json';