Skip watch tests on Node v20 on darwin, unskip them on v22 (#129)

* Skip watch tests Signed-off-by: Matteo Collina <hello@matteocollina.com> * add node 23 Signed-off-by: Matteo Collina <hello@matteocollina.com> --------- Signed-off-by: Matteo Collina <hello@matteocollina.com>
mcollina · Nov 21, 2024 · b2e1775 · b2e1775
1 parent 367fede
commit b2e1775
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 25 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -16,7 +16,7 @@ jobs:
 
     strategy:
       matrix:
-        node-version: [18.x, 20.x, 21.x, 22.x]
+        node-version: [18.x, 20.x, 21.x, 22.x, 23.x]
         os: [ubuntu-latest, windows-latest]
         exclude:
           - os: windows-latest

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -26,6 +26,7 @@
     "@sinonjs/fake-timers": "^13.0.2",
     "@types/node": "^22.2.0",
     "desm": "^1.3.0",
+    "semver": "^7.6.3",
     "snazzy": "^9.0.0",
     "standard": "^17.1.0",
     "typescript": "^5.3.2"

diff --git a/test/watch.test.js b/test/watch.test.js
@@ -5,9 +5,10 @@ import { join } from 'desm'
 import { mkdtemp, cp, writeFile, rm } from 'node:fs/promises'
 import path from 'node:path'
 import { once } from 'node:events'
+import semver from 'semver'
 
-// These tests are currently broken on node v22
-const skip = process.platform === 'darwin' && process.version.startsWith('v22')
+// These tests are currently broken on some node versions
+const skip = process.platform === 'darwin' && semver.satisfies(process.version, '>=20.16.0 <22.10.0')
 
 test('watch', { skip }, async (t) => {
   const { strictEqual, completed, match } = tspl(t, { plan: 3 })