Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for yaml config file #105

Merged
merged 2 commits into from
Oct 11, 2024
Merged

Add support for yaml config file #105

merged 2 commits into from
Oct 11, 2024

Conversation

jsumners
Copy link
Contributor

WIP

@jsumners
Copy link
Contributor Author

@mcollina please approve the CI run. I need to see what happens on Windows.

@jsumners jsumners marked this pull request as ready for review October 11, 2024 10:36
Copy link
Owner

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jsumners
Copy link
Contributor Author

Looks like #104 is needed regardless. I was hoping adding this feature would negate needing to do anything else special for Windows 😢.

@mcollina
Copy link
Owner

Should I land #104 then?

@jsumners
Copy link
Contributor Author

I think so. I can then rebase and we can rerun these tests to see if they're fixed before issuing a new release.

@jsumners
Copy link
Contributor Author

Ping for workflow run @mcollina (thanks GitHub).

Copy link
Owner

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@mcollina mcollina merged commit 2d06c47 into mcollina:main Oct 11, 2024
7 checks passed
@jsumners
Copy link
Contributor Author

image

@jsumners jsumners deleted the rcfile branch October 12, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants