-
-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for yaml config file #105
Conversation
@mcollina please approve the CI run. I need to see what happens on Windows. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Looks like #104 is needed regardless. I was hoping adding this feature would negate needing to do anything else special for Windows 😢. |
Should I land #104 then? |
I think so. I can then rebase and we can rerun these tests to see if they're fixed before issuing a new release. |
Ping for workflow run @mcollina (thanks GitHub). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
WIP