Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: initialize file size #33

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Conversation

burgerni10
Copy link
Contributor

@burgerni10 burgerni10 commented Sep 28, 2022

The currentSize was initialised to zero, causing the rolling to not happen on restarting the transport.

Fix #34

Copy link
Collaborator

@feugy feugy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @burgerni10!

pino-roll.js Outdated Show resolved Hide resolved
@mcollina
Copy link
Owner

@burgerni10 are you still interested in finishing this work? It conflicts right now

@burgerni10
Copy link
Contributor Author

burgerni10 commented Mar 19, 2024

@burgerni10 are you still interested in finishing this work? It conflicts right now

Hi @mcollina, I've rebased my PR and adapted a test. Since we now retrieve the initial file size, it shifts the log to the next file. I've removed one log (number 7) because it would have removed file number 3 (because of the rotation).

@mcollina mcollina merged commit f040620 into mcollina:main Mar 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Current size wrongly initialised to zero
3 participants