Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: prevent reusing dev-server #976

Merged
merged 1 commit into from
Sep 28, 2024
Merged

Conversation

mcollovati
Copy link
Owner

Quarkus tests reuse the same application instance, unless tests define different profiles or test resources. However, the JVM is always the same and Flow reuses the existing dev server instance.
This can cause errors when the application is restarted if frontend files are forcibly deleted.
This change make sure that the dev server is always stopped and restarted.

Quarkus tests reuse the same application instance, unless tests define
different profiles or test resources. However, the JVM is always the same
and Flow reuses the existing dev server instance.
This can cause errors when the application is restarted if frontend files
are forcibly deleted.
This change make sure that the dev server is always stopped and restarted.
@quarkus-hilla-bot
Copy link
Contributor

Format Checker Report

All files are correctly formatted

Copy link

Test Results

 58 files  ±0   58 suites  ±0   12m 19s ⏱️ -3s
176 tests ±0  176 ✅ ±0  0 💤 ±0  0 ❌ ±0 
260 runs  ±0  260 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 77fff60. ± Comparison against base commit 5ac3404.

@mcollovati mcollovati merged commit 20154ca into main Sep 28, 2024
10 checks passed
@mcollovati mcollovati deleted the test/do-not-reuse-devserver branch September 28, 2024 13:32
@github-actions github-actions bot added the released Issue has been released label Oct 12, 2024
Copy link

This issue has been resolved in 24.5.0-alpha5 (Release
Notes
)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
format:checked released Issue has been released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant