feat(ui): Always select all for search bar shortcut (fixes zealdocs#1033

)

Previously, the search bar focus shortcut would only select all if the
search bar was not focused. This change makes select all happen all the
time, making the keyboard shortcut consistent no matter what is focused.

src/libs/ui/mainwindow.cpp

@@ -164,7 +164,7 @@ MainWindow::MainWindow(Core::Application *app, QWidget *parent) :
     for (auto it = searchBarFocusShortcuts.begin(); it != searchBarFocusShortcuts.end(); ++it) {
         shortcut = new QShortcut(*it, this);
         connect(shortcut, &QShortcut::activated,
-                ui->lineEdit, static_cast<void (SearchEdit::*)()>(&SearchEdit::setFocus));
+                ui->lineEdit, static_cast<void (SearchEdit::*)()>(&SearchEdit::setFocusByShortcut));
     }
 
     // Duplicate current tab.

src/libs/ui/widgets/searchedit.cpp

@@ -90,6 +90,14 @@ bool SearchEdit::event(QEvent *event)
     return true;
 }
 
+void SearchEdit::setFocusByShortcut() {
+    // When want the keyboard shortcut that focuses the search bar to always have the same
+    // behavior, even if the search bar is already focused. focusInEvent won't be called if it's
+    // already focused so we work around that by clearing focus before setting focus.
+    clearFocus();
+    setFocus();
+}
+
 void SearchEdit::focusInEvent(QFocusEvent *event)
 {
     QLineEdit::focusInEvent(event);

src/libs/ui/widgets/searchedit.h

@@ -44,6 +44,7 @@ class SearchEdit : public QLineEdit
     void clearQuery();
     void selectQuery();
     void setCompletions(const QStringList &completions);
+    void setFocusByShortcut();
 
 protected:
     bool event(QEvent *event) override;