Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crates with + in version return 404 via meuse #33

Closed
stefos-pd opened this issue Dec 3, 2020 · 5 comments
Closed

Crates with + in version return 404 via meuse #33

stefos-pd opened this issue Dec 3, 2020 · 5 comments

Comments

@stefos-pd
Copy link

Downloading a crate from meuse returns a 404 if the crate version contains a + sign.

tested with openssl-src, flatc and a few other crates.

From crates.io the following works as expected:

curl -v -L "https://crates.io/api/v1/crates/flatc/0.1.0+1.12.0/download" -o tmpdl
curl -v -L "https://crates.io/api/v1/crates/openssl-src/111.10.1+1.1.1g/download" -o tmpdl

via meuse I get a 404 on:
curl -v -L "https://mirror.company.com/api/v1/mirror/flatc/0.1.0+1.12.0/download" -o tmpdl
curl -v -L "https://mirror.company.com/api/v1/mirror/openssl-src/111.10.1+1.1.1g/download" -o tmpdl

but 200 on:
curl -v -L "https://mirror.company.com/api/v1/mirror/unicase/2.6.0/download" -o tmpdl

So it seems that versions with a + are not working atm.

@martijndegouw
Copy link

The logs show the following message:
meuse.api.default uri not found: :get /api/v1/mirror/flatc/0.1.0+1.12.0/download

@mcorbin
Copy link
Owner

mcorbin commented Dec 3, 2020

Hello, thanks for the report. I will take a look.

@mcorbin
Copy link
Owner

mcorbin commented Dec 3, 2020

I found the root cause (it's related to the library I use for routing), I will release a version with a fix during the evening.

mcorbin added a commit that referenced this issue Dec 3, 2020
#33

This commit fix a bug where using characters like "+" in crates names
was causing issues with Meuse.
@mcorbin
Copy link
Owner

mcorbin commented Dec 3, 2020

The release https://github.com/mcorbin/meuse/releases/tag/v1.1.2 should fix the issue.

@stefos-pd
Copy link
Author

This resolves the issue! Thanks for the super speedy fix 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants