Fix issue #41 Different ply returned by same position #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use nth ply move from .pgn in nth ply position in move related rules.
clang-10.0.0 warns about this misleading indentation as follows: > scout.cpp: In function 'void Scout::search(Thread*)': > scout.cpp:302:11: warning: this 'if' clause does not guard... [-Wmisleading-indentation] > 302 | if (move) > | ^~ > scout.cpp:304:15: note: ...this statement, but the latter is misleadingly indented as if it were guarded by the ' > if' > 304 | pos.do_move(move, *st++, pos.gives_check(move)); > | ^~~ This looks like a bug to me as the condition `move==MOVE_NONE` will cause a NULL point dereference in `do_move`. Signed-off-by: Ali Polatel <alip@exherbo.org>
search: add braces around do_move
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use nth ply move from .pgn in nth ply position in move related rules.