Fix mcustiel/phiremock-client#4 #5
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcustiel
reviewed
Sep 28, 2020
| @@ -51,7 +50,9 @@ public function createPhiremockClient(Host $host, Port $port): Phiremock | |||
| $this->createRemoteConnection(), | |||
| $this->phiremockFactory->createV2UtilsFactory()->createExpectationToArrayConverter(), | |||
| $this->phiremockFactory->createV2UtilsFactory()->createArrayToExpectationConverter(), | |||
| $this->phiremockFactory->createV2UtilsFactory()->createScenarioStateInfoToArrayConverter() | |||
| $this->phiremockFactory->createV2UtilsFactory()->createScenarioStateInfoToArrayConverter(), | |||
| $this->phiremockFactory->findRequestFactoryInterface(), | |||
There was a problem hiding this comment.
These methods don't exist in phiremock-common.
I see you created an extended version here, but since server and client use laminas the dependency for http-factory and discovery should probably be there.
| { | ||
| public function findRequestFactoryInterface(): RequestFactoryInterface | ||
| { | ||
| if (!class_exists('\Http\Discovery\Psr17FactoryDiscovery', true)) { |
There was a problem hiding this comment.
If we require php-http/factory to work. Then it should be in the "require" section, not in the "require-dev"
|
In the next weeks I will create a new branch for the next major version and apply the changes there. Thanks for the proposal. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #4 (didn't want to duplicate issue).