Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mangadex has refactored the search API response #44

Closed
MxBlu opened this issue Sep 12, 2021 · 1 comment
Closed

Mangadex has refactored the search API response #44

MxBlu opened this issue Sep 12, 2021 · 1 comment

Comments

@MxBlu
Copy link
Contributor

MxBlu commented Sep 12, 2021

Looks like Mangadex has changed fields in the response object from an API search (namely, Chapter.search(), though looks like its a more general issue).

src/util.js:178 throws an error since initialResponse doesn't have the field "result", which is now "data".

 APIRequestError: The API did not respond the correct structure for a search request:
[object Object]

(BTW maybe JSON.stringify the response for printing)

Tried patching it but no dice, it generated empty Chapter objects as results. Looks like there's further patching to do.

@md-y
Copy link
Owner

md-y commented Sep 14, 2021

Fixed in new release, 5.5.1

@md-y md-y closed this as completed Sep 14, 2021
Stevox404 added a commit to Stevox404/mangadex-full-api that referenced this issue Jul 13, 2022
d99aa1a Merge branch 'md-y:master' into master
c007772 Structure constructor conditional is now falsy
68409f6 Update npm
6b5813c Add properties, search params, and manga stats
7f672d6 Fix retrieving chapter pages
d11a0d8 Update npm and types
b1352ba Add related manga property
0cf17fe Flatten spread arguments to allow normal arrays
1cec0a4 Fix convertLegacyId
13f0835 Update npm and mocha ver
fb9fe24 Revert getMultipleIds change
16fe9cf Rewrite readme
8cc2523 Add search method for users, role, and relations
f3e6e06 Optimize Util
5b00f7a Change typing script and improve JSDoc comments
880283f Fix error when the cache location is not specified
fe05ab2 Make rest parameters non-optional md-y#46
2d4c0ed Make search/feed parameters optional
02d2d99 Fix API array return result refactor (md-y#44)
c2b49f9 Merge branch 'md-y:master' into master
0261f74 Update npm/types/docs
4757106 Remove external chapters from pages test
33062e1 Migrate relationships to new location (MD 5.2.23)

git-subtree-dir: src/Libraries/mfa
git-subtree-split: d99aa1a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants