Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Target netstandard2.0 for libraries, target net8 for tests, and switch to github actions for CI #147

Merged
merged 12 commits into from
Jan 20, 2024

Conversation

mdabros
Copy link
Owner

@mdabros mdabros commented Jan 20, 2024

A first step in an effort to get SharpLearning up to date with tools.

  • Use github actions for CI. First iteration of this is without nuget publishing.
  • Target net8 for test projects.
  • Target netstandard2.0 only for libraries . So removing net461 targeting.

Since BinaryFormatter is deprecated from net7 it was necessary to use EnableUnsafeBinaryFormatterSerialization in the SharpLearning.InputOutput.Test project file. Likewise this will also be necessary for other projects using the GenericBinarySerializer. The GenericBinarySerializer will be removed in a later release since it has been deemed unsafe.

  <PropertyGroup>
    <EnableUnsafeBinaryFormatterSerialization>true</EnableUnsafeBinaryFormatterSerialization>
  </PropertyGroup>

Read more here:
https://learn.microsoft.com/en-us/dotnet/core/compatibility/serialization/7.0/binaryformatter-apis-produce-errors#recommended-action

@mdabros mdabros changed the title Github actions: Add dotnet.yml for CI Target netstandard2.0 for libraries, target net8 for tests, and switch to github actions for CI Jan 20, 2024
@mdabros mdabros assigned mdabros and unassigned mdabros Jan 20, 2024
@mdabros mdabros merged commit 70ef474 into master Jan 20, 2024
2 checks passed
@mdabros mdabros deleted the github-actions-ci branch January 20, 2024 21:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant