Include end of input symbol in LR(0) tables #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #41.
When implementing this originally, I omitted the end of input symbol from LR(0) parse tables. This is possibly because Louden 1997 doesn't include such a column in one of its examples.
However, since grammar classification uses the parsing tables, it wasn't able to detect that this grammar had a reduce/reduce conflict:
Of course, this grammar is cyclic and has no terminal symbols, so if classification doesn't check for reduce-reduce conflicts using a table that omits the end of input symbol, it will think there are no conflicts (since they were dropped when creating the table from the automaton).
LL(1) classification has a similar problem, which I'll address in another PR.