Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings about using URI.escape method #35

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Envek
Copy link

@Envek Envek commented Mar 2, 2020

  • Replace obsolete URI.escape method with CGI.escape (no specs failed so it should be fine, I think)
  • Fix deprecation warnings about using ActionView::Base.new in specs
  • Include newer Rails and Ruby versions into CI matrix

@olimart
Copy link

olimart commented Mar 13, 2020

@mdeering would be great to get this one merged. Thanks

@szechyjs
Copy link

@mdeering any chance of getting this merged and released?

@andyjeffries
Copy link

If we can't get it merged and @mdeering isn't responding, is there a more up to date fork of this gem the community is using?

@olimart
Copy link

olimart commented Nov 14, 2020

Get rid of the dependency with a simple helper

hash = Digest::MD5.hexdigest(email)
"https://secure.gravatar.com/avatar/#{hash}.png?height=#{size}&width=#{size}"

@michaelglass
Copy link

thanks @olimart!
the url above should be

"https://secure.gravatar.com/avatar/#{hash}.png?s=#{size}"

see: https://en.gravatar.com/site/implement/images#size

@sunny sunny mentioned this pull request Jan 10, 2021
@paulhklam1122
Copy link

@mdeering can we get this merged, please? It breaks when upgrading to ruby 3. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants