Added logic to save the error body only for failed requests (#81)

Added logic to save the error body only for failed requests
mderevyankoaqa · Dec 6, 2022 · 2a0935a · 2a0935a
1 parent 97b2d1a
commit 2a0935a
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/.../java/io/github/mderevyankoaqa/influxdb2/visualizer/result/SampleResultPointProvider.java b/.../java/io/github/mderevyankoaqa/influxdb2/visualizer/result/SampleResultPointProvider.java
@@ -44,11 +44,11 @@ public Point getPoint() {
      * @param isToBeSaved set to true if body need to be saved; otherwise false.
      * @return the normalized string if parameter @param isToBeSaved set to true; 'noData' string otherwise.
      */
-     private String getErrorBodyToBeSaved(boolean isToBeSaved)
+     private String getErrorBodyToBeSaved(boolean isToBeSaved, boolean isSuccessful)
      {
          String errorResponseBody;
 
-         if (isToBeSaved)
+         if (isToBeSaved && isSuccessful)
          {
              errorResponseBody = this.getErrorBody();
          }
@@ -107,7 +107,7 @@ private Point getDefaultPoint() {
                 .addTag(RequestMeasurement.Tags.RESULT_CODE, this.sampleResultContext.getSampleResult().getResponseCode())
                 .addTag(RequestMeasurement.Tags.ERROR_MSG, this.getAssertionFailure())
                 .addTag(RequestMeasurement.Tags.SAMPLE_TYPE, this.sampleResultContext.getSamplerType())
-                .addTag(RequestMeasurement.Tags.ERROR_RESPONSE_BODY, this.getErrorBodyToBeSaved(this.sampleResultContext.isErrorBodyToBeSaved()))
+                .addTag(RequestMeasurement.Tags.ERROR_RESPONSE_BODY, this.getErrorBodyToBeSaved(this.sampleResultContext.isErrorBodyToBeSaved(), !this.sampleResultContext.getSampleResult().isSuccessful()))
                 .addField(RequestMeasurement.Fields.ERROR_COUNT, this.sampleResultContext.getSampleResult().getErrorCount())
                 .addField(RequestMeasurement.Fields.REQUEST_COUNT, this.sampleResultContext.getSampleResult().getSampleCount())
                 .addField(RequestMeasurement.Fields.RECEIVED_BYTES, this.sampleResultContext.getSampleResult().getBytesAsLong())