Skip to content

Commit

Permalink
Do a full clone so that we have enough information to determine the r…
Browse files Browse the repository at this point in the history
…elease (#29)

This PR ensures that in the release workflow we do a full clone, so that setuptools_scm has enough information to compute a version number.

We don't strictly need this if we only ever expect to be making releases from a tagged commit (which seems likely), but the failure mode if this is left out is that we compute a wrong version. So it seems better to include it. If some future version of setuptools_scm makes this an error, it should be safe to remove this.

See pypa/setuptools-scm#480 for more discussion.
  • Loading branch information
mdickinson authored Aug 21, 2022
1 parent 5751a56 commit ed8d3f4
Showing 1 changed file with 2 additions and 0 deletions.
2 changes: 2 additions & 0 deletions .github/workflows/on-release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@ jobs:

steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Set up Python 3.10
uses: actions/setup-python@v4
with:
Expand Down

0 comments on commit ed8d3f4

Please sign in to comment.