Refactor and fix handling of goodreads api when currently reading contains a single item #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Put all goodreads api related methods in a dedicated class - Put all github api related methods in a dedicated class - Put all output formatting in a dedicated class - Prepare the ground for dependency injection and more increased testability - Didn't change any behavior This commit is intended to prepare future work. Design choices made here are also a matter of preference.
When getting reviews from goodreads api, if a single result was returned, it was not returned as an array. I fixed this by casting the result to an array.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request
The refactor has been produced in order to improve on the architecture, I am willing to add several optional features to this project in the future, with the idea of preserving the current default behavior.
I can keep it on my fork, but I would be happy to contribute more to this repo if you are interested, let me know!