Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore original LGPL license #30

Merged
merged 4 commits into from
Jul 9, 2024
Merged

Conversation

cbodley
Copy link
Contributor

@cbodley cbodley commented Jul 9, 2024

restores the original license from https://github.com/nose-devs/nose

replacing the MIT license requires sign-off from the two copyright holders:

  • Michael Mintz
  • Christian Clauss

copied directly from lgpl.txt of the original nose repository

Signed-off-by: Casey Bodley <cbodley@redhat.com>
Signed-off-by: Casey Bodley <cbodley@redhat.com>
@cbodley
Copy link
Contributor Author

cbodley commented Jul 9, 2024

proposed resolution to #16. requesting approvals from @mdmintz @cclauss

@mdmintz
Copy link
Owner

mdmintz commented Jul 9, 2024

@cbodley Please fix flake8 issues. Lines have a 79-char limit.

@mdmintz
Copy link
Owner

mdmintz commented Jul 9, 2024

@cbodley Still flake8:
E131 continuation line unaligned for hanging indent

setup.py Outdated
Comment on lines 109 to 110
"License :: OSI Approved :: GNU Library or " +
"Lesser General Public License (LGPL)",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"License :: OSI Approved :: GNU Library or " +
"Lesser General Public License (LGPL)",
("License :: OSI Approved :: GNU Library or "
"Lesser General Public License (LGPL)"),

@emilazy
Copy link

emilazy commented Jul 9, 2024

Thanks for this PR. I would recommend restoring the AUTHORS file and adding the two new ones, as currently there is no adequate attribution of copyright.

@mdmintz mdmintz merged commit c3aa742 into mdmintz:master Jul 9, 2024
12 checks passed
@cbodley
Copy link
Contributor Author

cbodley commented Jul 9, 2024

@mdmintz @cclauss thanks very much for the speedy reviews!

@cbodley
Copy link
Contributor Author

cbodley commented Jul 9, 2024

Thanks for this PR. I would recommend restoring the AUTHORS file and adding the two new ones, as currently there is no adequate attribution of copyright.

@emilazy this is probably worth creating a separate issue for

@mdmintz mdmintz mentioned this pull request Jul 9, 2024
@mdmintz
Copy link
Owner

mdmintz commented Jul 9, 2024

Merged!

@emilazy
Copy link

emilazy commented Jul 9, 2024

Thank you for addressing the licensing concerns.

Thanks for this PR. I would recommend restoring the AUTHORS file and adding the two new ones, as currently there is no adequate attribution of copyright.

@emilazy this is probably worth creating a separate issue for

Looks like there’s #31 now. Thanks for putting in work here; I was just considering it in the context of general licence/copyright compliance.

@mdmintz
Copy link
Owner

mdmintz commented Jul 9, 2024

The AUTHORS file has been added too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment