Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the api.Node.baseURIObject entry #7520

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented Nov 27, 2020

This is a Gecko "ChromeOnly" attribute not exposed to the web:
https://github.com/mozilla/gecko-dev/blob/8a4aa0c699d9ec281d1f576c9be1c6c1f289e4e7/dom/webidl/Node.webidl#L109

The string "baseURIObject" does not appear in Chromium or WebKit source,
apart from one instane in a gecko_dom.js as part of a test suite.

https://developer.mozilla.org/en-US/docs/Web/API/Node/baseURIObject
should be redirected to Node.

This is a Gecko "ChromeOnly" attribute not exposed to the web:
https://github.com/mozilla/gecko-dev/blob/8a4aa0c699d9ec281d1f576c9be1c6c1f289e4e7/dom/webidl/Node.webidl#L109

The string "baseURIObject" does not appear in Chromium or WebKit source,
apart from one instane in a gecko_dom.js as part of a test suite.

https://developer.mozilla.org/en-US/docs/Web/API/Node/baseURIObject
should be redirected to Node.
@foolip foolip requested a review from ddbeck November 27, 2020 11:41
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 27, 2020
@foolip
Copy link
Collaborator Author

foolip commented Nov 27, 2020

Once approved, I can take care of redirecting https://developer.mozilla.org/en-US/docs/Web/API/Node/baseURIObject. Or if the reviewer would like to do it and merge directly, that's also OK.

@foolip
Copy link
Collaborator Author

foolip commented Nov 27, 2020

#7521 is very similar but with an extra error in the data thrown in. Dealing with them together would probably still make sense though.

@foolip foolip requested review from Elchi3 and removed request for ddbeck November 27, 2020 15:08
Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I created the redirect and also removed baseURIObject from the main Node page.

Is there a list you work from for these? I think there are (at least) 4 more that are mentioned here: https://wiki.developer.mozilla.org/en-US/docs/Web/API/Node#Obsolete_properties

@Elchi3 Elchi3 merged commit 2a6abca into mdn:master Nov 27, 2020
@foolip foolip deleted the baseURIObject branch November 27, 2020 15:25
@foolip
Copy link
Collaborator Author

foolip commented Nov 27, 2020

@Elchi3 I don't have a list, these were just the two I came across in #7515.

3 of the remaining ones in https://wiki.developer.mozilla.org/en-US/docs/Web/API/Node#Obsolete_properties are #6545, feedback on the proposed resolution appreciated.

The remaining rootNode indeed looks ripe for removal, however. I'll give it a go.

@foolip
Copy link
Collaborator Author

foolip commented Nov 27, 2020

The go was given in #7524.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants