Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the api.Node.rootNode entry #7524

Merged
merged 1 commit into from
Nov 27, 2020
Merged

Remove the api.Node.rootNode entry #7524

merged 1 commit into from
Nov 27, 2020

Conversation

foolip
Copy link
Collaborator

@foolip foolip commented Nov 27, 2020

This was in Gecko, but quickly reverted and renamed to getRootNode():
mozilla/gecko-dev@4967a99
mozilla/gecko-dev@9adeb96
mozilla/gecko-dev@9404a17

https://developer.mozilla.org/en-US/docs/Web/API/Node/rootNode
should be redirected to getRootNode instead.

This was in Gecko, but quickly reverted and renamed to getRootNode():
mozilla/gecko-dev@4967a99
mozilla/gecko-dev@9adeb96
mozilla/gecko-dev@9404a17

https://developer.mozilla.org/en-US/docs/Web/API/Node/rootNode
should be redirected to getRootNode instead.
@foolip foolip requested a review from Elchi3 November 27, 2020 15:36
@queengooborg queengooborg added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Nov 27, 2020
@Elchi3
Copy link
Member

Elchi3 commented Nov 27, 2020

https://developer.mozilla.org/en-US/docs/Web/API/Node/rootNode
should be redirected to getRootNode instead.

Done and also removed rootNode from the Node main page.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, unsure if I should merge given the failing CI atm.

@foolip
Copy link
Collaborator Author

foolip commented Nov 27, 2020

It was the labeled that failed, which doesn't really matter, but I'll try to get it passing before merging for good measure.

@foolip
Copy link
Collaborator Author

foolip commented Nov 27, 2020

Ok, all sorted.

@foolip foolip merged commit 8aac7fd into mdn:master Nov 27, 2020
@foolip foolip deleted the rootNode branch November 27, 2020 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants