Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add compat data for ServiceWorker #1010

Merged
merged 7 commits into from
Feb 13, 2018
Merged

Conversation

bunnybooboo
Copy link
Contributor

@bunnybooboo bunnybooboo changed the title Add compat data ServiceWorker Add compat data for ServiceWorker Feb 11, 2018
@Elchi3 Elchi3 added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Feb 12, 2018
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A question about why is there no flag information on this for Edge? I think it should. beside of this, it is very good.

"version_added": "40"
},
"edge": {
"version_added": "17"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"flags" (the other SW entries have it – why not this one?)

"version_added": "40"
},
"edge": {
"version_added": "17"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"flags"

"version_added": "40"
},
"edge": {
"version_added": "17"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"flags"

"version_added": "40"
},
"edge": {
"version_added": "17"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"flags"

@bunnybooboo
Copy link
Contributor Author

bunnybooboo commented Feb 13, 2018

On consulting Edge Dev API catalog, and several blogs, I'm lead to believe the preview in 16 is enabled only via the pref. Screenshots within some of those are all I have to go by. Version 17 will have service workers enabled by default.

So really it should look like..?

"edge": [
            {
              "version_added": "16",
              "flags": [
                {
                  "type": "preference",
                  "name": "Enable service workers"
                }
              ]
            },
            {
              "version_added": "17"
            }
          ],

@bunnybooboo
Copy link
Contributor Author

bunnybooboo commented Feb 13, 2018

Further to discussion in #1013 this should finally be up to scratch. 🤞

@bunnybooboo
Copy link
Contributor Author

bunnybooboo commented Feb 13, 2018

Via discussion w/ Samsung dev advocate on Mastodon added Samsung Internet data. Source on v4.0

Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I got to the same conclusion. LGTM, R+

@teoli2003 teoli2003 merged commit 6cad84a into mdn:master Feb 13, 2018
@bunnybooboo bunnybooboo deleted the ServiceWorker branch February 13, 2018 20:21
dontcallmedom pushed a commit to dontcallmedom/browser-compat-data that referenced this pull request Mar 17, 2018
* Add compat data ServiceWorker

* Correct Edge version number

* Add Edge preference flags

* Remove value_to_set

* Add Saunsung Internet v 4.x compat

* Correct Samsung Internet version number

* Edit Edge 16 to flag, 17 to default
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants