-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add compat data for ServiceWorker #1010
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A question about why is there no flag information on this for Edge? I think it should. beside of this, it is very good.
api/ServiceWorker.json
Outdated
"version_added": "40" | ||
}, | ||
"edge": { | ||
"version_added": "17" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"flags" (the other SW entries have it – why not this one?)
api/ServiceWorker.json
Outdated
"version_added": "40" | ||
}, | ||
"edge": { | ||
"version_added": "17" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"flags"
api/ServiceWorker.json
Outdated
"version_added": "40" | ||
}, | ||
"edge": { | ||
"version_added": "17" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"flags"
api/ServiceWorker.json
Outdated
"version_added": "40" | ||
}, | ||
"edge": { | ||
"version_added": "17" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"flags"
On consulting Edge Dev API catalog, and several blogs, I'm lead to believe the preview in 16 is enabled only via the pref. Screenshots within some of those are all I have to go by. Version 17 will have service workers enabled by default. So really it should look like..?
|
Further to discussion in #1013 this should finally be up to scratch. 🤞 |
Via discussion w/ Samsung dev advocate on Mastodon added Samsung Internet data. Source on v4.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I got to the same conclusion. LGTM, R+
* Add compat data ServiceWorker * Correct Edge version number * Add Edge preference flags * Remove value_to_set * Add Saunsung Internet v 4.x compat * Correct Samsung Internet version number * Edit Edge 16 to flag, 17 to default
https://developer.mozilla.org/en-US/docs/Web/API/ServiceWorker
as per #1002 notes on ESR might need editing