Adds compat data for AnimationEvent #1017
Conversation
|
Fixes #965 |
Elchi3
added
the
data:api 🐇
There was a problem hiding this comment.
There is a member missing here https://developer.mozilla.org/en-US/docs/Web/API/AnimationEvent/animationName
api/AnimationEvent.json
Outdated
| }, | ||
| "chrome": [ | ||
| { | ||
| "version_added": "1", |
There was a problem hiding this comment.
Please swap this around, the more relevant version is the unprefixed one. (the first element will be rendered as the main compat cell in the MDN tables, other version ranges will be put into the expandable details.)
"chrome": [
{
"version_added": "43"
}
{
"version_added": "1",
"prefix": "webkit"
},
],
api/AnimationEvent.json
Outdated
| "mdn_url": "https://developer.mozilla.org/docs/Web/API/AnimationEvent", | ||
| "support": { | ||
| "webview_android": { | ||
| "version_added": null, |
api/AnimationEvent.json
Outdated
| "support": { | ||
| "webview_android": { | ||
| "version_added": null, | ||
| "prefix": "webkit" |
| }, | ||
| "chrome": [ | ||
| { | ||
| "version_added": "43" |
There was a problem hiding this comment.
Is this how we note when something was unprefixed? @Elchi3
There was a problem hiding this comment.
Yes, the array indicates support ranges.
So, there is a support range starting from version 43 where this is fully available and unprefixed.
Then there is a second support ranges where it was available (version not known) and prefixed.
The rendered tables take the first array element as the one to render in the main cell. The other support ranges will be treated as secondary and put into the expandable info. See e.g. https://developer.mozilla.org/en-US/docs/Web/API/CanvasRenderingContext2D/imageSmoothingEnabled#Browser_compatibility
api/AnimationEvent.json
Outdated
| } | ||
| ], | ||
| "chrome_android": { | ||
| "version_added": "43" |
There was a problem hiding this comment.
true for original version added. "43" is for when the prefix was removed.
api/AnimationEvent.json
Outdated
| "mdn_url": "https://developer.mozilla.org/docs/Web/API/AnimationEvent/AnimationEvent", | ||
| "support": { | ||
| "webview_android": { | ||
| "version_added": false |
There was a problem hiding this comment.
Should be true and prefix removed in "43". Repeat for Chrome and Chrome Android.
| "version_added": true | ||
| }, | ||
| "chrome_android": { | ||
| "version_added": "43" |
There was a problem hiding this comment.
All three versions of Chrome should have the same data as for the constructor.
api/AnimationEvent.json
Outdated
| "version_added": "4" | ||
| }, | ||
| "webview_android": { | ||
| "version_added": null |
api/AnimationEvent.json
Outdated
| "version_removed": "23" | ||
| }, | ||
| "opera_android": { | ||
| "version_added": null |
|
Well done! We're almost there. |
Fixes #965