-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Window event deprecate #10356
Merged
Merged
Window event deprecate #10356
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
data:api 🐇
Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
label
May 7, 2021
ddbeck
approved these changes
May 12, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🎉
ddbeck
requested changes
May 12, 2021
ddbeck
approved these changes
May 14, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! 🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes a number of windows events to match the deprecation status of their on_event handler, as discussed in #10224.
This includes Window event for vrdisplayblur vrdisplayconnect vrdisplayactivate vrdisplaydeactivate vrdisplaydisconnect vrdisplayfocus vrdisplaypointerrestricted vrdisplaypointerunrestricted vrdisplaypresentchange
It also creates a deprecated appinstalled event based on onappinstalled (when this merges, need to change https://developer.mozilla.org/en-US/docs/Web/API/Window/appinstalled_event to point to this new event).