Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WorkerGlobalScope - add close() and close_event to match onclose() #10416

Merged
merged 1 commit into from
May 12, 2021

Conversation

hamishwillee
Copy link
Collaborator

This is part of fixing #10224

WorkerGlobalScope has the (deprecated) onclose() event handler property, but not the associated method close() and event close_event. This copies the event hanlder for the other two items. This then ensures that BCD matches MDN for this property.

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label May 10, 2021
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 🎉

@ddbeck ddbeck merged commit 7166d1a into mdn:main May 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants