Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Safari iOS 4.3 #11174

Merged
merged 1 commit into from
Jun 21, 2021
Merged

Remove Safari iOS 4.3 #11174

merged 1 commit into from
Jun 21, 2021

Conversation

queengooborg
Copy link
Collaborator

This PR removes Safari iOS 4.3 from the browser data, and adjusts everything that is set as iOS 4.3 to 4.2 instead. Safari iOS 4.3's WebKit version is the exact same as iOS 4.2's, as confirmed by querying WhatIsMyBrowser.

@github-actions github-actions bot added data:browsers 🌍 Data about browsers (versions, release dates, etc). This data is used for validation. data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML labels Jun 21, 2021
@foolip
Copy link
Collaborator

foolip commented Jun 21, 2021

This one looks small and simple enough. I found two sources for what the UA string on iOS 4.3 was:

https://stackoverflow.com/a/5738659 says:

Mozilla/5.0 (iPhone; U; CPU iPhone OS 4_3_2 like Mac OS X; en-us) AppleWebKit/533.17.9 (KHTML, like Gecko) Version/5.0.2 Mobile/8H7 Safari/6533.18.5

https://gist.github.com/moomerman/1240682 says among other things:

Mozilla/5.0 (iPhone; U; CPU iPhone OS 4_2_1 like Mac OS X; en-us) AppleWebKit/533.17.9 (KHTML, like Gecko) Version/5.0.2 Mobile/8C148 Safari/6533.18.
Mozilla/5.0 (iPhone; U; CPU iPhone OS 4_3_1 like Mac OS X; en-us) AppleWebKit/533.17.9 (KHTML, like Gecko) Version/5.0.2 Mobile/8G4 Safari/6533.18.5

So 533.17.9 seems very likely correct, for 4.3 and we can fold it into 4.2. It also seems like the Safari version was 5.0.2, which makes sense since the WebKit version of Safari 5 we have is 533.16.

Copy link
Collaborator

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Safari versions here are all 5, and that makes sense considering the WebKit versions and that the UA string for iOS had 5.0.2 here.

@foolip foolip merged commit f3e3413 into mdn:main Jun 21, 2021
@queengooborg queengooborg deleted the browsers/safari-ios/4.3 branch June 21, 2021 17:22
@foolip foolip mentioned this pull request Jun 21, 2021
ddbeck added a commit to ddbeck/browser-compat-data that referenced this pull request Jun 24, 2021
ddbeck added a commit that referenced this pull request Jun 24, 2021
* Bump version to v3.3.9

* Add release note for #11080

* Add release note for #10774

* Add release note for #11149

* Add release note for #11174

* Add release note for #11229

* Add release note for #10700

* Add stats and release date
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:browsers 🌍 Data about browsers (versions, release dates, etc). This data is used for validation. data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants