-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove MediaStreamConstraints dictionary from BCD #12397
Conversation
Is there an MDN PR for this? I don't think that capturing whether Ultimately I don't think https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#parameters-and-parameter-object-features will work here, because something like |
api/MediaDevices.json
Outdated
@@ -402,6 +402,102 @@ | |||
"deprecated": false | |||
} | |||
}, | |||
"constraints_audio_parameter": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to use this data for automation, is there a written rule to name this? What happens when the spec changes the argument name, e.g. to constraintObject
? Will the name here also change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rules are in https://github.com/mdn/browser-compat-data/blob/main/docs/data-guidelines.md#parameters-and-parameter-object-features. For the most part the names match the spec and I've been changing some to match, but I can't imagine they all match.
I would guess that in the vast majority of cases there's just one dictionary argument and the argument name can be ignored / assumed to match. That only leaves cases with multiple dictionary arguments needing to match on the name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've removed these subfeatures since their data matches their parent, and as indicated, there's no need for the individual audio
and video
features anyways!
This PR removes the
MediaStreamConstraints
dictionary from BCD, folding its two parameters into the only function that uses it (api.MediaDevices.getUserMedia
). This is also preliminary work for the removal of theMediaTrackConstraints
dictionary as well.