Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove FileSystemFlags dictionary from BCD #12766

Merged
merged 2 commits into from
Dec 29, 2021

Conversation

queengooborg
Copy link
Contributor

This PR removes the FileSystemFlags dictionary from BCD.

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 10, 2021
@queengooborg queengooborg added needs content update This PR needs a corresponding update to mdn/content to update the documentation needs-release-note 📰 labels Oct 10, 2021
@queengooborg queengooborg removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Oct 13, 2021
@ddbeck ddbeck added the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Oct 19, 2021
@ddbeck
Copy link
Collaborator

ddbeck commented Oct 19, 2021

I don't understand the content update. It's not removed. This seems to be a different treatment than we've used in the past. Why?

@queengooborg
Copy link
Contributor Author

queengooborg commented Oct 20, 2021

My reasoning for performing a simple unlink of BCD rather than remove the documentation for these pages was because of the number of API members that used the dictionary. In some cases, it makes more sense to keep MDN pages for the dictionary and reference it (for example, CryptoKeyPair) than it is to remove it.

Looking through the MDN pages again, there are only two members using the dictionary, so a simple unlink wasn't the right move. I'll open up a content PR to fix that. However, I think the needs content update can be removed from this PR, since the BCD removal can be done independently now that the table has been unlinked on MDN web docs.

@queengooborg queengooborg removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Oct 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants