Add HTMLInputElement showPicker() #14444
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
github-actions
bot
added
the
data:api 🐇
|
Since mdn/content#11753 got merged, https://developer.mozilla.org/en-US/docs/Web/API/HTMLInputElement/showPicker is now live. |
|
@foolip Can you review by any chance? |
foolip
reviewed
Jan 7, 2022
|
@beaufortfrancois just to set expectations, I don't always post a review with suggestions 10 seconds after being asked 😄 |
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
Loved it though ;) |
|
@foolip Argh Shall we add edge version number or wait? |
|
@beaufortfrancois a rebase of this should fix the CI failure now. |
Done! |
foolip
approved these changes
Jan 7, 2022
jpmedley
pushed a commit
that referenced
this pull request
Jan 10, 2022
Co-authored-by: Philip Jägenstedt <philip@foolip.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds HTMLInputElement.showPicker()
See related PR at mdn/content#11753