Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete api.HTMLFrameSetElement.onstorage #15158

Merged
merged 2 commits into from
Mar 24, 2022
Merged

Delete api.HTMLFrameSetElement.onstorage #15158

merged 2 commits into from
Mar 24, 2022

Conversation

queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Feb 28, 2022 •
edited
Loading

This PR adapts the storage event of the HTMLFrameSetElement API to conform to the new events structure. This PR focuses on deleting the onstorage entry, leaving the addition of storage_event to #15477.

@queengooborg
Adapt api.HTMLFrameSetElement.onstorage to new events structure
d8cf4d9 
This PR adapts the storage event of the HTMLFrameSetElement API to conform to the new events structure.

Note: there are no MDN pages associated with these events, so there will be no corresponding content PR. Any broken MDN URLs in BCD have been removed.
@queengooborg queengooborg added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Feb 28, 2022
@queengooborg queengooborg mentioned this pull request Feb 28, 2022
Closed
@foolip
Copy link
Contributor

foolip commented Mar 4, 2022

Can you update all "onstorage" entries at the same time? I haven't checked the spec, but suspect we should be left with just one "storage_event" entry somewhere, and not on HTMLFrameSetElement.

@queengooborg
Copy link
Contributor Author

It seems that this is actually just inherited from WindowEventHandlers; see the related spec IDL. I only see two onstorage entries -- one here, and one in WindowEventHandlers.

@foolip
Copy link
Contributor

foolip commented Mar 8, 2022

Yes, this is all because of WindowEventHandlers. So can we clean it all up in one PR? :)

@Elchi3
Copy link
Member

Elchi3 commented Mar 23, 2022

Should this be closed in favor of #15477?

@queengooborg queengooborg changed the title Adapt api.HTMLFrameSetElement.onstorage to new events structure Delete api.HTMLFrameSetElement.onstorage Mar 23, 2022
@queengooborg
Copy link
Contributor Author

The onstorage feature still needs to be removed, which I feel is somewhat out-of-scope for #15477. I've updated this PR to instead perform only the removal, preventing conflicts between the two PRs!

@Elchi3 Elchi3 merged commit a88ce87 into mdn:main Mar 24, 2022
@queengooborg queengooborg deleted the api/HTMLFrameSetElement/storage/events branch March 24, 2022 18:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Elchi3 Elchi3 Elchi3 approved these changes

Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@queengooborg @foolip @Elchi3