-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Demix change event from GlobalEventHandlers #16544
Demix change event from GlobalEventHandlers #16544
Conversation
This pull request has merge conflicts that must be resolved before it can be merged. |
This pull request has merge conflicts that must be resolved before it can be merged. |
1 similar comment
This pull request has merge conflicts that must be resolved before it can be merged. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here are the place that fire this event in the HTML spec:
https://html.spec.whatwg.org/#checkbox-state-(type=checkbox)
https://html.spec.whatwg.org/#radio-button-state-(type=radio)
https://html.spec.whatwg.org/#file-upload-state-(type=file)
https://html.spec.whatwg.org/#common-input-element-events
https://html.spec.whatwg.org/#send-select-update-notifications
https://html.spec.whatwg.org/#focus-update-steps
All of those concern <input>
or <select>
elements.
https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/change_event also mentions <textarea>
. I can't find where this happens in the spec but have filed whatwg/html#8073.
I suggest adding "change_event" entries to <input>
, <select>
and <textarea>
.
Per #16651 (comment) I think maybe it's better to go with a single entry on |
This PR demixes the
change
event from the GlobalEventHandlers mixin.