Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demix drag/drop events from GlobalEventHandlers #16556

Merged
merged 10 commits into from
Jul 14, 2022
Merged

Demix drag/drop events from GlobalEventHandlers #16556

merged 10 commits into from
Jul 14, 2022

Conversation

queengooborg
Copy link
Contributor

This PR demixes the drag and drop events from the GlobalEventHandlers mixin.

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 5, 2022
@queengooborg queengooborg mentioned this pull request Jun 9, 2022
Closed
@queengooborg queengooborg added the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jun 13, 2022
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

1 similar comment
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

foolip
foolip requested changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rather than add new entries, I think the drag* and drop events on Document should be moved to HTMLElement, since the target of these events are elements with the draggable attribute. In my testing it seems like it has to be HTML elements, not arbitrary elements.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

foolip
foolip requested changes Jul 11, 2022
View reviewed changes
api/HTMLElement.json Outdated Show resolved Hide resolved
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@queengooborg queengooborg mentioned this pull request Jul 12, 2022
Merged
@queengooborg queengooborg removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jul 12, 2022
@queengooborg queengooborg merged commit 8f44cf8 into mdn:main Jul 14, 2022
@queengooborg queengooborg deleted the api/GlobalEventHandlers/dragdrop branch July 14, 2022 14:30
@Elchi3
Copy link
Member

Elchi3 commented Aug 31, 2022

Rather than add new entries, I think the drag* and drop events on Document should be moved to HTMLElement, since the target of these events are elements with the draggable attribute. In my testing it seems like it has to be HTML elements, not arbitrary elements.

I think some content work didn't happen here. There is a broken compat table here https://developer.mozilla.org/en-US/docs/Web/API/Document/drag_event

I guess that page shouldn't exist and redirect to https://developer.mozilla.org/en-US/docs/Web/API/HTMLELement/drag_event?

What was the plan here?

@Elchi3 Elchi3 added the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Aug 31, 2022
@Elchi3 Elchi3 mentioned this pull request Sep 1, 2022
Merged
@Elchi3
Copy link
Member

Elchi3 commented Sep 1, 2022

I opened mdn/content#20206 to remove DnD event pages under Document that now sit there without compat tables.

@queengooborg queengooborg removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jan 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip requested changes

Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@queengooborg @Elchi3 @foolip