Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demix load event from GlobalEventHandlers #16659

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Demix load event from GlobalEventHandlers #16659

merged 2 commits into from
Jul 25, 2022

Conversation

queengooborg
Copy link
Contributor

@queengooborg queengooborg commented Jun 14, 2022 •
edited
Loading

This PR demixes the load event from the GlobalEventHandlers mixin.

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 14, 2022
@queengooborg queengooborg mentioned this pull request Jun 14, 2022
Closed
@queengooborg queengooborg added the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jun 14, 2022
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

1 similar comment
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

foolip
foolip requested changes Jul 5, 2022
View reviewed changes
Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is going to be similar to #16610, lots of events in different places.

This will take time to get right and review, so maybe it makes more sense to handle one interface at a time, doing both "error" and "load" event together?

api/Document.json Outdated Show resolved Hide resolved
@github-actions
Copy link

github-actions bot commented Jul 9, 2022

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@queengooborg queengooborg changed the title Demix load events from GlobalEventHandlers Demix load event from GlobalEventHandlers Jul 13, 2022
@foolip
Copy link
Contributor

foolip commented Jul 13, 2022

@queengooborg in case you missed it: #16659 (review)

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@queengooborg queengooborg mentioned this pull request Jul 24, 2022
Merged
@queengooborg queengooborg force-pushed the api/GlobalEventHandlers/load branch from a93c173 to 6b73cb7 Compare July 24, 2022 00:24
@queengooborg queengooborg removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jul 24, 2022
@queengooborg queengooborg merged commit 854b855 into mdn:main Jul 25, 2022
@queengooborg queengooborg deleted the api/GlobalEventHandlers/load branch July 25, 2022 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip approved these changes

Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @foolip