Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove progress event from GlobalEventHandlers #16718

Merged
merged 3 commits into from
Jun 21, 2022

Conversation

queengooborg
Copy link
Contributor

This PR demixes the progress event from the GlobalEventHandlers mixin.

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 18, 2022
@queengooborg queengooborg added the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jun 18, 2022
Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few different "progress" events, notably one on XMLHttpRequest, but others too. But the only one that fires on an object that's part of the Node hierarchy is the one on HTMLMediaElement. The "progress_event" entries already exist, so this should be changes to just removing the entry, adding nothing new.

@foolip foolip changed the title Demix progress event from GlobalEventHandlers Remove progress event from GlobalEventHandlers Jun 21, 2022
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@foolip
Copy link
Contributor

foolip commented Jun 21, 2022

@queengooborg can you resolve conflicts?

@queengooborg
Copy link
Contributor Author

@foolip May we hold off on merging these pull requests until the content PRs have at least been submitted?

@foolip
Copy link
Contributor

foolip commented Jun 21, 2022

@queengooborg sorry, I wasn't paying attention to labels on my phone. Are you keeping track of what was already merged and needs content changes?

@queengooborg
Copy link
Contributor Author

No worries! Basically what I've been doing is awaiting approval of the BCD PRs, and then once I know that we've got the story mapped out in BCD, I'm heading over to mdn/content to open a PR containing similar changes. That way, everything is kept in sync as much as possible!

@queengooborg
Copy link
Contributor Author

And I'm now realizing that there are some events that don't actually need any updates since there are no GlobalEventHandlers pages for the particular events -- I'm going through now to find them and remove the label, and apparently this is one of them!

@queengooborg queengooborg removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jun 21, 2022
@foolip foolip merged commit 2849b7d into mdn:main Jun 21, 2022
@queengooborg queengooborg deleted the api/GlobalEventHandlers/progress branch June 21, 2022 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants