-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove progress event from GlobalEventHandlers #16718
Remove progress event from GlobalEventHandlers #16718
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are a few different "progress" events, notably one on XMLHttpRequest
, but others too. But the only one that fires on an object that's part of the Node
hierarchy is the one on HTMLMediaElement
. The "progress_event" entries already exist, so this should be changes to just removing the entry, adding nothing new.
This pull request has merge conflicts that must be resolved before it can be merged. |
@queengooborg can you resolve conflicts? |
@foolip May we hold off on merging these pull requests until the content PRs have at least been submitted? |
@queengooborg sorry, I wasn't paying attention to labels on my phone. Are you keeping track of what was already merged and needs content changes? |
No worries! Basically what I've been doing is awaiting approval of the BCD PRs, and then once I know that we've got the story mapped out in BCD, I'm heading over to |
And I'm now realizing that there are some events that don't actually need any updates since there are no GlobalEventHandlers pages for the particular events -- I'm going through now to find them and remove the label, and apparently this is one of them! |
This PR demixes the
progress
event from the GlobalEventHandlers mixin.