Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Demix wheel event from GlobalEventHandlers #16762

Merged
merged 8 commits into from
Jul 12, 2022
Merged

Demix wheel event from GlobalEventHandlers #16762

merged 8 commits into from
Jul 12, 2022

Conversation

queengooborg
Copy link
Contributor

This PR demixes the wheel event from the GlobalEventHandlers mixin.

@github-actions github-actions bot added the data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 21, 2022
@queengooborg queengooborg mentioned this pull request Jun 21, 2022
Closed
@queengooborg queengooborg added the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jun 21, 2022
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

1 similar comment
@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

foolip
foolip requested changes Jun 29, 2022
View reviewed changes
Copy link
Contributor

@foolip foolip left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's keep only the entry on Element, that's the target per https://w3c.github.io/uievents/#event-type-wheel and the event bubbles.

These differences in the data need to be investigated:

  • Chrome 31 or 61?
  • Supported on Safari iOS or not?

@github-actions
Copy link

This pull request has merge conflicts that must be resolved before it can be merged.

@foolip
Copy link
Contributor

foolip commented Jul 11, 2022

The question of Chrome 31 or 61 still needs addressing here.

@queengooborg
Copy link
Contributor Author

I just ran the collector and it looks like this is a more complicated issue than originally anticipated. As reported by the collector, on Element, support was introduced in Chrome 61, however on Document, it was supported since Chrome 31.

We should probably keep the event on Document as well.

@foolip
Copy link
Contributor

foolip commented Jul 12, 2022

@queengooborg did you use http://mdn-bcd-collector.appspot.com/tests/api/HTMLElement/wheel_event? There's no test for Element...

@foolip
Copy link
Contributor

foolip commented Jul 12, 2022 •
edited
Loading

Using http://software.hixie.ch/utilities/js/live-dom-viewer/?saved=10459 to test the version before/after I've confirmed:

  • Chrome 31
  • Firefox 17
  • Safari 7 is plausible (works in Safari 8, but not 6)

@foolip
Copy link
Contributor

foolip commented Jul 12, 2022

We should probably keep the event on Document as well.

I don't think so, or can you create a test case where the target is a Document and not some Element?

@queengooborg queengooborg mentioned this pull request Jul 12, 2022
Merged
@queengooborg queengooborg removed the needs content update This PR needs a corresponding update to mdn/content to update the documentation label Jul 12, 2022
@queengooborg queengooborg merged commit 5246229 into mdn:main Jul 12, 2022
@queengooborg queengooborg deleted the api/GlobalEventHandlers/wheel branch July 12, 2022 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@foolip foolip foolip approved these changes

Assignees
No one assigned
Labels
data:api Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @foolip