Add missing api.ShadowRoot.slotchange_event feature #17674
Conversation
This PR is a part of a project to add missing interfaces and interface features to BCD that are from an active spec (including WICG specs) and is supported in at least one browser. This particular PR adds the missing `slotchange_event` member of the ShadowRoot API, populating the results using data from the [mdn-bcd-collector](https://mdn-bcd-collector.appspot.com) project (v6.1.2). Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/ShadowRoot/slotchange_event Safari Source Commit: WebKit/WebKit@3e059ee _Check out the [collector's guide on how to review this PR](https://github.com/foolip/mdn-bcd-collector#reviewing-bcd-changes)._
queengooborg
added
the
data:api
|
This was removed in #16733 and shouldn't be added back. |
|
Hmm...what about the event handler? The event handler is present on this interface in the IDL from Webref. |
|
It's the same situation as keydown and many other events on We could consider the presence of the properties on I don't think the guidelines cover this stuff very well. |
|
The compat table on MDN is broken since we removed this event in #16733, see https://developer.mozilla.org/en-US/docs/Web/API/ShadowRoot/onslotchange I'm not really sure what our guidelines should be exactly. The |
|
OK, so it looks like there were content changes still needed for #16733 when it was merged. I think that https://developer.mozilla.org/en-US/docs/Web/API/ShadowRoot/onslotchange should redirect to https://developer.mozilla.org/en-US/docs/Web/API/HTMLSlotElement/slotchange_event. |
|
In this case it could also make sense to document the event as bubbling up to |
|
I believe this PR should be closed then. |
|
Sweet, thanks @Elchi3! |
This PR is a part of a project to add missing interfaces and interface features to BCD that are from an active spec (including WICG specs) and is supported in at least one browser. This particular PR adds the missing
slotchange_eventmember of the ShadowRoot API, populating the results using data from the mdn-bcd-collector project (v6.1.2).Tests Used: https://mdn-bcd-collector.appspot.com/tests/api/ShadowRoot/slotchange_event
Safari Source Commit: WebKit/WebKit@3e059ee
Check out the collector's guide on how to review this PR.