Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URLSearchParams has() and delete() have new value option #20110

Merged
merged 3 commits into from
Jun 20, 2023

Conversation

hamishwillee
Copy link
Collaborator

@hamishwillee hamishwillee commented Jun 13, 2023

FF115 adds support for new value option to URLSearchParams.has() and delete() methods. This adds the value.

Lots of tracking info in whatwg/url#735 and testing shows:

Tests on WPT are:

Upshot, need to confirm that safari and node values are OK to progress this.

Related docs work can be tracked in mdn/content#27172

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 13, 2023
@hamishwillee
Copy link
Collaborator Author

FYI @queengooborg - some questions above about best versions to use for node etc

@@ -353,6 +393,7 @@
"forEach": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/API/URLSearchParams/forEach",
"spec_url": "https://url.spec.whatwg.org/#dom-urlsearchparams-urlsearchparams",
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, also added spec link to top level for each of the items added by the iterator in the IDL (because these aren't expanded out in spec.

@Elchi3
Copy link
Member

Elchi3 commented Jun 19, 2023

Yes, that should be correct.

  • Node added it in 20.2.0 but latest version is 20.0.0 in BCD. Don't know how I work out engines etc to add that entry - is 20.0.0 close enough?

I think we tried to avoid minor and patch nodejs versions in the past. I'm torn. I think either we add them in as needed or we agree we only want major release lines like nodejs has in their own docs. The issue for this discussion is #18777

@queengooborg
Copy link
Collaborator

Generally speaking, we have added minor versions of NodeJS to BCD when needed, and this qualifies. I think that sticking to just major versions of NodeJS is too vague for our consumers.

@Elchi3 Elchi3 merged commit 9434d7f into mdn:main Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants