-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a CHANGELOG.md file to track schema changes. #2041
Conversation
5516dd5
to
a999875
Compare
708eb2a
to
eb82801
Compare
eb82801
to
04687ee
Compare
An alternative would be to add notable changes to the tags directly. I've done that experimentally for 0.0.45 here: https://github.com/mdn/browser-compat-data/releases/tag/v0.0.45 and it appears nicely in the release history: https://github.com/mdn/browser-compat-data/releases I think I would prefer that and can make that my habit whenever I release a new package version. What do you think? |
As long as you make it a habit, that's fine by me. Ideally it'd be in the git repo properly (I'm not 100% sure, but I don't think GitHub stores Release descriptions as part of the tags in the repo, so they aren't really portable). Also, people may not look at the Releases page, and it's not possible for others to contribute to it. That said, your workflow matters the most since you're the maintainer, and if it's a choice between releases as the place to find breaking changes, or nothing, releases is obviously better :) |
OK, I'm trying out github releases for this and will keep this open for now to add more release notes to past tags. |
Happy so far with the release notes for 0.0.50 to 0.0.58: https://github.com/mdn/browser-compat-data/releases |
Did you mean to include the bit of code after the total features? |
No, it's probably not the right place. I've added the snippet to the publishing instructions instead in #3158. |
I'm happy with the release notes we are providing here: https://github.com/mdn/browser-compat-data/releases I don't think I (we) want to maintain this in a separate file additionally, but thanks for having opened this PR! It prompted us to get a process going for actually doing release notes somewhere :-) |
Resolves #1992. The reason I'd like the project to have a Changelog is so I can more easily update my Explorer webapp whenever a schema change occurs.
This is meant to track:
spec_url
attribute was added to track WHATWG/W3C specs for a given feature, or if themdn_url
attribute was removed from the dataset.description
was changed from allowing onlyString
to allowing either aString
or anArray
, in order to support localization.mdn_url
tomdn_link
.mathml/
directory was added in Begin work on converting MathML data #1740.status
mandatory.prefix
andalternative_name
mutually exclusive like in Makeprefix
andalternative_name
mutually exclusive #1836.I don't think it should track every change to the dataset as that'd cause unnecessary friction, and the commit log should be sufficient for tracking that information.
Maybe it should also track adding new browsers? I'm not sure about that one.