Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add data for HTMLSelectElement showPicker #20852

Merged
merged 1 commit into from
Nov 16, 2023

Conversation

lukewarlow
Copy link
Contributor

@lukewarlow lukewarlow commented Oct 1, 2023

Summary

Add data for HTMLSelectElement showPicker

Test results and supporting details

Pull request for html spec: whatwg/html#9754

Chrome Status Entry: https://chromestatus.com/feature/5111537299881984

Content PR: mdn/content#29406

Related issues

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Oct 1, 2023
@queengooborg
Copy link
Collaborator

I noticed this was marked as a draft, but this looks ready to go?

@lukewarlow
Copy link
Contributor Author

@queengooborg I was waiting till the spec PR got merged. Currently the spec link won't work. Happy to unmark as draft if you think that's fine

@queengooborg
Copy link
Collaborator

Ah, thanks for pointing that out! If you'd like, we can mark this as non-standard for now, and then follow up with another PR to add the spec URL when it becomes standard; or, we can leave this unmerged until the spec changes are official. I have no preference either way!

@lukewarlow lukewarlow marked this pull request as ready for review November 16, 2023 12:42
@lukewarlow
Copy link
Contributor Author

@queengooborg the spec PR just got merged so this is ready to go.

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The Firefox bug is marked as fixed in 121. https://bugzilla.mozilla.org/show_bug.cgi?id=1854112 and the Chromestatus says shipping in 121.

Can you update this PR?

@lukewarlow lukewarlow force-pushed the select-showpicker branch 2 times, most recently from 79d1552 to a5cdc72 Compare November 16, 2023 13:00
@lukewarlow
Copy link
Contributor Author

Added Firefox flagged support and marked as stable in chrome from 121 (here's the PR to flip it on waiting for review https://chromium-review.googlesource.com/c/chromium/src/+/5034127)

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

@lukewarlow
Copy link
Contributor Author

(sorry last minute change realised it's also out in Safari Tech Preview)

@Elchi3 Elchi3 merged commit 43dc6b4 into mdn:main Nov 16, 2023
4 checks passed
},
"chrome_android": "mirror",
"edge": "mirror",
"firefox": {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI only the bug now says this is enabled in "nightly" so have updated this to preview in #21280

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants