Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for Deno v1.38 #21144

Merged
merged 1 commit into from
Nov 3, 2023
Merged

Updates for Deno v1.38 #21144

merged 1 commit into from
Nov 3, 2023

Conversation

bartlomieju
Copy link
Contributor

@bartlomieju bartlomieju commented Nov 1, 2023

Summary

Changes for compat data for Deno v1.38

Test results and supporting details

The blog post with detailed changes will be available at https://deno.com/blog/v1.38

Related issues

Fixes #21151

@github-actions github-actions bot added data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript data:browsers 🌍 Data about browsers (versions, release dates, etc). This data is used for validation. labels Nov 1, 2023
@Elchi3
Copy link
Member

Elchi3 commented Nov 2, 2023

@bartlomieju thanks for your PR! Do you know if there is data for Deno releases available programmatically? We are trying to automate updating this file and we have done so for other engines. (See #21137 for how a bot now takes care of updates). Would be cool to set this up for Deno, too!

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

@Elchi3 Elchi3 merged commit 0a7e672 into mdn:main Nov 3, 2023
3 checks passed
@bartlomieju bartlomieju deleted the deno_1.38 branch November 6, 2023 21:15
@bartlomieju
Copy link
Contributor Author

Hey @Elchi3, sorry for a slow response. Currently we don't have a way to programatically get this data, besides checking type declarations available in the given version. We use that to generate documentation automatically, so I guess we could diff these declarations to see what's changed. Is there some README I could look at too see how the update script works?

@teoli2003
Copy link
Contributor

teoli2003 commented Nov 7, 2023

Hi!

There is no README, but I can describe what is needed as I wrote the scripts for Chrome (Android/Desktop + Webview), Firefox (Android/Desktop), and Edge.

What we want to achieve

We want to automatically create a PR when a new tool is released (and, for the major browsers, when a new public Beta is released). The PR update automatically the browser versions files: firefox.json, firefox-android.json, webview.json, edge.json, deno.json, … The review of the PR and its merging is done by humans.

What information we need

For Deno, we need to be able to fill these fields:

  • A version number that is the key.
  • release_date: the release date of a given version
  • release_notes: the structure is trivial and can be deduced from the version number: https://github.com/denoland/deno/releases/tag/v1.38.0
  • engine. This is hardcoded to V8.
  • engine_version.

Capture d’écran 2023-11-07 à 09 12 14

Where the information should be

We need a way to query this information, either via an API, or by reading files on the web (on GitHub, it works well; I did it for some data relating to Edge).

Doing the script

I can write the script (if I have the missing information), and have you review it.

Other info

The current scripts are living at https://github.com/mdn/browser-compat-data/tree/main/scripts/update-browser-releases (and are run automatically once a day)

Elchi3 pushed a commit to Elchi3/browser-compat-data that referenced this pull request Nov 14, 2023
@bartlomieju
Copy link
Contributor Author

@teoli2003 I'm so sorry, but I missed your response. If you are still interested in writing the script I will definitely provide all the help and context needed. This would be great if we could automate the process.

Engine_version: <--- This is the part I don't know how. A GitHub file?

I can expose this information at a URL, similarly how we expose the latest version at https://dl.deno.land/canary-latest.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:browsers 🌍 Data about browsers (versions, release dates, etc). This data is used for validation. data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deno added EventSource in 1.38
3 participants