Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chrome and chrome_android entries in RemotePlayback.json #21486

Merged
merged 6 commits into from
Feb 8, 2024

Conversation

muyao-xu
Copy link
Contributor

@muyao-xu muyao-xu commented Dec 5, 2023

Chrome is shipping Remote Playback API on desktop: https://chromestatus.com/feature/5778318691401728

@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Dec 5, 2023
@queengooborg
Copy link
Collaborator

Hi @muyao-xu, thank you for your PR and welcome to BCD!

Because the interface is defined, the mdn-bcd-collector states this interface as supported on desktop. Do you know if there is a good way to programmatically and automatically test for support (i.e., without calling .prompt() or otherwise displaying prompts that require user action)?

@muyao-xu
Copy link
Contributor Author

muyao-xu commented Jan 9, 2024

Hi @queengooborg ,

Sorry for the late reply.
The Remote Playback API defines that the browser rejects the watchAvailability() or prompt() calls with a NotSupportedError when the API is not supported. I don't think it's possible to bypass this step but this process should be able to complete without user actions.

@muyao-xu
Copy link
Contributor Author

muyao-xu commented Feb 7, 2024

Hi @queengooborg :)

Is there anything else I need to do to get this PR merged?

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for being slow, @muyao-xu!

Would you mind also updating:

That would be very much appreciated!

@github-actions github-actions bot added the data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML label Feb 8, 2024
@muyao-xu
Copy link
Contributor Author

muyao-xu commented Feb 8, 2024

Done!

Copy link
Member

@Elchi3 Elchi3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@Elchi3 Elchi3 merged commit ae73d13 into mdn:main Feb 8, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API data:html 📄 Compat data for HTML elements. https://developer.mozilla.org/docs/Web/HTML
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants