Update Safari imagesrcset and imagesizes #21586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
data:api 🐇
|
It's true, I missed the flag in the code implemented back in 2019. The flag got enabled just recently, so this should, in fact, be 17.2. |
Elchi3
approved these changes
Dec 12, 2023
There was a problem hiding this comment.
Great catch @tunetheweb and thanks for confirming @jdatapple 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Responsive preloads (
imagesrcsetandimagesizes) was enabled in Safari 17.2 but was incorrectly marked as supported from Safari 13.This was changed in #21267 due to this comment: #21267 (comment) but I'm not sure what that is based upon. It was behind a flag for a while, but wasn't enabled by default until 17.2 and MDN encourages removal of flag details after it goes to stable. @jdatapple @Elchi3 any comments here?
Test results and supporting details
WPT here shows it isn't enabled on stable (currently still 17.1): https://wpt.fyi/results/preload/link-header-preload-imagesrcset.html?label=stable&label=master&aligned
It is enabled in Safari Preview https://wpt.fyi/results/preload/link-header-preload-imagesrcset.html?label=experimental&label=master&aligned and is enabled in 17.2:
https://webkit.org/blog/14787/webkit-features-in-safari-17-2/
Related issues
Last updated in #21267