Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Firefox 122: Update motion-related features #21844

Merged
merged 2 commits into from
Jan 11, 2024

Conversation

dipikabh
Copy link
Contributor

@dipikabh dipikabh commented Jan 4, 2024

Targets

Target release: Firefox 122
Release date: Jan 23, 2024

Summary

This PR proposes changes in addition to the ones in #21678.

  1. Updates to css/types/ray.json, which corresponds to the BCD table on the ray() page:
  1. Updates to css/properties/offset-path.json:
  • For <basic-shape> and <coord-box>, updated firefox to 122 and experimental to false.

Supporting details

Related issues

@dipikabh dipikabh requested a review from Elchi3 January 4, 2024 17:33
@github-actions github-actions bot added the data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS label Jan 4, 2024
teoli2003 pushed a commit to mdn/data that referenced this pull request Jan 6, 2024
### Description

- Fixes #676 
To address listing the values for `<ray-size>`, I've referred to the
instructions in the `mdn/data/docs` section [Store the information in
the
JSONs](https://github.com/mdn/data/blob/main/docs/updating_css_json.md#store-the-information-in-the-jsons),
where it mentions how to handle when "syntax contains references to
specific values".
   
I've added `"syntaxes"` for `ray()` in `syntaxes.json`. I've included
only the keys that have further values. I'm not sure if that's the
correct way to do it though. I am assuming this should be okay because
the complete syntax exists in `functions.json`.

**UPDATE**: `"syntaxes"` is not supported, was getting lint errors. I've
reverted to use `syntax` but expanded the `<ray-size>` and `<position>`
values inline.

- I'm also using this PR to update `ray()` function syntax (mdn/content
PR to add [Formal
syntax](https://pr31514.content.dev.mdn.mozit.cloud/en-US/docs/Web/CSS/ray#formal_syntax)).
With Firefox122 coming out on Jan 23, 2024, `ray()` will be supported by
default, making it standard across browsers. So I've also updated the
status to `standard` (BCD PR with [ray() status
update](https://github.com/mdn/browser-compat-data/pull/21844/files#diff-5153a0172f96a72ece248c9d29cea659e3ecd45c45d81d57b0b6f2f00c57e7b3R98)).
### Motivation

Addressing an issue as well as updating the syntax

### Related issues and pull requests

mdn/browser-compat-data#21844
mdn/content#31514
@queengooborg queengooborg merged commit 0c7f2a7 into mdn:main Jan 11, 2024
6 checks passed
@dipikabh
Copy link
Contributor Author

Thanks for reviewing, @queengooborg!

@dipikabh dipikabh deleted the fx122-css-motion branch January 11, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css 🎨 Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants